Skip to content

NO SNOW: skip reduce desc query test in sql simplifier disabled test suite#4238

Merged
sfc-gh-yuwang merged 2 commits into
mainfrom
yuwang-fix-desc-test
May 28, 2026
Merged

NO SNOW: skip reduce desc query test in sql simplifier disabled test suite#4238
sfc-gh-yuwang merged 2 commits into
mainfrom
yuwang-fix-desc-test

Conversation

@sfc-gh-yuwang

@sfc-gh-yuwang sfc-gh-yuwang commented May 27, 2026

Copy link
Copy Markdown
Collaborator
  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-yuwang sfc-gh-yuwang requested a review from a team as a code owner May 27, 2026 18:30
@sfc-gh-jrose sfc-gh-jrose added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label May 27, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.12%. Comparing base (1253e7e) to head (dc341c7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4238      +/-   ##
==========================================
- Coverage   95.40%   95.12%   -0.29%     
==========================================
  Files         171      171              
  Lines       44205    44205              
  Branches     7548     7548              
==========================================
- Hits        42174    42049     -125     
- Misses       1247     1340      +93     
- Partials      784      816      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sfc-gh-yuwang sfc-gh-yuwang enabled auto-merge (squash) May 27, 2026 20:02
@sfc-gh-yuwang sfc-gh-yuwang merged commit 9cb0c3e into main May 28, 2026
28 of 29 checks passed
@sfc-gh-yuwang sfc-gh-yuwang deleted the yuwang-fix-desc-test branch May 28, 2026 01:18
@github-actions github-actions Bot locked and limited conversation to collaborators May 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants